Debugger enhancements V2 - new hardware#338
Open
kktos wants to merge 46 commits into
Open
Conversation
Add a whole bunch of command Add Debugger in a window. Add INI file.
Add a whole bunch of command Add Debugger in a window. Add INI file.
(cherry picked from commit b3c2648)
(cherry picked from commit 739e1a7)
(cherry picked from commit 879fd7e)
(cherry picked from commit 7fad3e4)
(cherry picked from commit a8e546d)
(cherry picked from commit 7026084)
(cherry picked from commit 5a9f652)
(cherry picked from commit 1975d5b)
Load a font only once (cherry picked from commit d56fa03)
(cherry picked from commit 0a5654a)
(cherry picked from commit b91bf9f)
(cherry picked from commit 5d93f1e)
(cherry picked from commit 38e0a15)
(cherry picked from commit 1f2aaf9)
(cherry picked from commit 23fb30f)
(cherry picked from commit ffd1eeb)
…d - Thx S. Horn (cherry picked from commit bf642d8)
(cherry picked from commit a05de23)
(cherry picked from commit 3781601)
(cherry picked from commit 368a835)
Slighty enhanced disasm to fall on right line ... still not perfect
(cherry picked from commit c0a61c0)
(cherry picked from commit d082739)
(cherry picked from commit aace16e)
…wasn't finding the symbol) Fix the symbol eval to return not found instead of addr 0 when not found (cherry picked from commit 409f78f)
Fix mouse coord display (cherry picked from commit 355252e)
(cherry picked from commit 9aa9507)
Fix user symbol file loader to handle empty lines and lines commented out ";" (cherry picked from commit 85af12d)
Fix in DebugInit to handle no ini file (cherry picked from commit 7c6416d)
Add command "load file addr" Fix symbol lookup to search either a symbol or an address Fix the disasm Bank to follow the current one depending of RAM or ROM Fix disasm to display symbol depending on the current bank (ROM/RAM) Disams: Change the label pos for a full line (cherry picked from commit ea2b5c6)
(cherry picked from commit 0064a5c)
(cherry picked from commit 0e3678d)
Fix the load command
Add debugger settings var (romdebug flag to allow ROM modif, bp_on_brk to have BRK viewed as breakpoint) (cherry picked from commit 38c8795)
Remove the keyboard shortcuts as they are replaced by buttons Allow to redefine keyboard bindings for the DBG (cherry picked from commit 3dfc2f5)
Fix the key bindings to handle the mods (cherry picked from commit 72c932f)
Allow command "load" to load in main RAM, banked RAM and banked ROM Add key bindings for bank up/down on memory dump (cherry picked from commit 5e6fd08)
…xxx as the dash is used for comments
Collaborator
|
Sorry, I missed this in time, and now we have conflicts again. I tried to resolve the conflicts myself, but having played with it for a while, I really think this needs to be done in three steps:
Could you do this? :) Ping me at mist64@mac.com once the first patch is ready, so I can apply it immediately, and it does not fall behind any more. The other two will then be less time critical. |
Collaborator
|
For reference: documentation is in #313. |
Collaborator
|
I moved all sources to src/ and .o files to build/ (to be consistent with the ROM build process) in 61fc63d, so one less step here. |
Collaborator
|
So for the remaining changes, I'd like to have them broken up like this:
and independently: cleanup work in the non-debugger code |
Collaborator
|
I separated out 1./2. into branch https://github.com/commanderx16/x16-emulator/tree/kktos-debugger-enhancements - maybe it's useful for a start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.