Skip to content

Add CMake support equivalent to Makefile#192

Closed
madebr wants to merge 9 commits into
commanderx16:masterfrom
madebr:cmake_rebase
Closed

Add CMake support equivalent to Makefile#192
madebr wants to merge 9 commits into
commanderx16:masterfrom
madebr:cmake_rebase

Conversation

@madebr

@madebr madebr commented Oct 26, 2019

Copy link
Copy Markdown
Contributor

This pr add support for the CMake build system. This allows building x16-emulator on Visual Studio.
It is based on #64 (rebased, squashed and with small modifications).
In addition, it adds:

  • documentation generation using CMake,
  • releases creation using CMake,
  • emscripten support using CMake,
  • cmake tests on CI services: travis-ci and Appveyor
  • support for conan: conan is a package manager aimed to developers that provides development packages. It is greatly useful for providing mingw on windows, emscripten on windows and linux and providing sdl2 on all platforms. I'm using it on appveyor and in the emscripten test on travis-ci.
    • I made sure that the cmake script contains no conan references.

@vii1: Please test
@sebastianvog @Frank-Buss : Please test emscripten/webassembly support + give blessing 😆

@madebr madebr force-pushed the cmake_rebase branch 2 times, most recently from 052976f to a066518 Compare November 3, 2019 11:33
@madebr

madebr commented Nov 3, 2019

Copy link
Copy Markdown
Contributor Author

I rebased this pr on current master (and use release 34 on ci)
appveyor: https://ci.appveyor.com/project/madebr/x16-emulator/builds/28576825
travis: https://travis-ci.com/madebr/x16-emulator/builds/134751553

@sebastianvog

Copy link
Copy Markdown
Contributor

@madebr anytthing particular you want me to check for emscripten? i am unfamiliar with cmake, but i can give it a try.

@madebr

madebr commented Nov 3, 2019

Copy link
Copy Markdown
Contributor Author

Hey @sebastianvog,
Just checking whether your workflow still works and if there is something wrong/missing.
The only difference should be the cmake configure step and an out-of-tree build.

@nigels-com

Copy link
Copy Markdown
Contributor

cmake makes me sad. But I don't have a better suggestion, unfortunately.

@madebr

madebr commented Jan 15, 2020

Copy link
Copy Markdown
Contributor Author

I'll close this one as cmake/Visual Studio support is unwanted atm.

@madebr madebr closed this Jan 15, 2020
jestin pushed a commit to jestin/x16-emulator that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants