Draft
Conversation
TylerPachal
commented
Jan 27, 2025
TylerPachal
commented
Jan 27, 2025
| count: count | ||
| } | ||
|
|
||
| Telemetry.measure_span(:read_stream_forward, telemetry_metadata, fn -> |
Author
There was a problem hiding this comment.
❓ Do we want the metrics to mimic the function names? Or should the metrics be lower level?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass on adding Telemetry, to address this issue: #163
I have only added a few measurements, one example of a "regular" metric and only "polling" metric. Once we are happy with these, we can add measurements in more places.
This PR is partially for getting a conversation going around metrics. But partially also to get something merged in that other people can build on.