fix: Relax validation of names, to allow special characters, apostrophes and hyphens#876
Open
curlyfriesplease wants to merge 2 commits intomasterfrom
Open
fix: Relax validation of names, to allow special characters, apostrophes and hyphens#876curlyfriesplease wants to merge 2 commits intomasterfrom
curlyfriesplease wants to merge 2 commits intomasterfrom
Conversation
curlyfriesplease
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
José
André
Müller
François
All people who cannot currently put their proper names into ESU.
This change will relax the name regex to look for 'Letters' as defined by Unicode, rather than strictly A-Z only, which will allow characters with diacritics like those above. Also, it will allow names with apostrophes and hyphens, like J-Train and D'Snazzle.
Why is this required?
We have been adopting a similar approach elsewhere, like with FSU, so this brings some consistency.
link to Jira ticket:
ENG-5017
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...