fix: In mobile view, moves the play pause button to the top left#868
Merged
curlyfriesplease merged 5 commits intomasterfrom Apr 15, 2026
Merged
fix: In mobile view, moves the play pause button to the top left#868curlyfriesplease merged 5 commits intomasterfrom
curlyfriesplease merged 5 commits intomasterfrom
Conversation
Contributor
Author
|
@AndyEPhipps Sorry mate one final addition to the play/pause things. Ought to have been included in the last one, my bad. |
AndyEPhipps
reviewed
Apr 15, 2026
| // Play icon needs to go to the top left on mobile | ||
| // as with the hero banner, the text container can | ||
| // overlap it | ||
| @media (max-width: ${mobileMaxWidth}px) { |
Contributor
There was a problem hiding this comment.
If possible, would probs prefer you just update the default mobile-first styles above, and use a M+ media query here
|
🎉 This PR is included in version 8.71.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
In mobile view, moves the play/pause button from the bottom left to the top left.
Why is this required?
Design QA: Without this, the button is overlapped by the hero banner's text
link to Jira ticket:
ENG-5005
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...