Skip to content

fix: In mobile view, moves the play pause button to the top left#868

Merged
curlyfriesplease merged 5 commits intomasterfrom
ENG-5005-video-banner-bugs
Apr 15, 2026
Merged

fix: In mobile view, moves the play pause button to the top left#868
curlyfriesplease merged 5 commits intomasterfrom
ENG-5005-video-banner-bugs

Conversation

@curlyfriesplease
Copy link
Copy Markdown
Contributor

@curlyfriesplease curlyfriesplease commented Apr 9, 2026

PR description

What is it doing?

In mobile view, moves the play/pause button from the bottom left to the top left.

Why is this required?

Design QA: Without this, the button is overlapped by the hero banner's text

link to Jira ticket:

ENG-5005

Quick Checklist:

  • My PR title follows the Conventional Commit spec.

  • I have filled out the PR description as per the template above.

  • I have added tests to cover new or changed behaviour.

  • I have updated any relevant documentation.

Important! - lastly, make sure to squash merge...

@curlyfriesplease curlyfriesplease changed the title In mobile view, moves the play button to the top left fix: In mobile view, moves the play pause button to the top left Apr 15, 2026
@curlyfriesplease curlyfriesplease marked this pull request as ready for review April 15, 2026 14:13
@curlyfriesplease
Copy link
Copy Markdown
Contributor Author

@AndyEPhipps Sorry mate one final addition to the play/pause things. Ought to have been included in the last one, my bad.

// Play icon needs to go to the top left on mobile
// as with the hero banner, the text container can
// overlap it
@media (max-width: ${mobileMaxWidth}px) {
Copy link
Copy Markdown
Contributor

@AndyEPhipps AndyEPhipps Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, would probs prefer you just update the default mobile-first styles above, and use a M+ media query here

Copy link
Copy Markdown
Contributor

@AndyEPhipps AndyEPhipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@curlyfriesplease curlyfriesplease merged commit 48720b3 into master Apr 15, 2026
9 checks passed
@curlyfriesplease curlyfriesplease deleted the ENG-5005-video-banner-bugs branch April 15, 2026 16:10
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 8.71.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants