Repository navigation
fix(parse): keep non-ASCII letters in heading ids #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
32969e2
fix(parse): keep non-ASCII letters in heading ids
adamdehaven e09a6b5
fix: do not use empty parent ID as heading prefix
adamdehaven fd910c9
fix(parse): drop marks and dedup suffixes from heading ids
farnabaz 87afca6
fix(parse): strip leading marks and hyphens from heading ids in one pass
farnabaz b1a6623
fix(parse): trim trailing hyphens from heading ids
farnabaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| ## Input | ||
|
|
||
| ```md | ||
| ## Café | ||
|
|
||
| ## Привет мир | ||
|
|
||
| ## 日本語の見出し | ||
|
|
||
| ## 🚀 | ||
| ``` | ||
|
|
||
| ## AST | ||
|
|
||
| ```json | ||
| { | ||
| "frontmatter": {}, | ||
| "meta": {}, | ||
| "nodes": [ | ||
| [ | ||
| "h2", | ||
| { | ||
| "id": "café" | ||
| }, | ||
| "Café" | ||
| ], | ||
| [ | ||
| "h2", | ||
| { | ||
| "id": "привет-мир" | ||
| }, | ||
| "Привет мир" | ||
| ], | ||
| [ | ||
| "h2", | ||
| { | ||
| "id": "日本語の見出し" | ||
| }, | ||
| "日本語の見出し" | ||
| ], | ||
| [ | ||
| "h2", | ||
| {}, | ||
| "🚀" | ||
| ] | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| ## HTML | ||
|
|
||
| ```html | ||
| <h2 id="café">Café</h2> | ||
| <h2 id="привет-мир">Привет мир</h2> | ||
| <h2 id="日本語の見出し">日本語の見出し</h2> | ||
| <h2>🚀</h2> | ||
| ``` | ||
|
|
||
| ## Markdown | ||
|
|
||
| ```md | ||
| ## Café | ||
|
|
||
| ## Привет мир | ||
|
|
||
| ## 日本語の見出し | ||
|
|
||
| ## 🚀 | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: comarkdown/comark
Length of output: 5235
🏁 Script executed:
Repository: comarkdown/comark
Length of output: 19914
Retain every Unicode number category.
The filter keeps
NdandNlbut dropsNo. For example,## ①loses its only number and receives no generated ID. The documented contract says generated IDs keep Unicode numbers. Use\p{N}and add a test for anNoheading.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents