Fix #417: Mark broken pipe handler thread as daemon#419
Open
HuiNeng6 wants to merge 3 commits into
Open
Conversation
… with SubProcess.scala Fixes issue com-lihaoyi#406
The broken pipe handler thread was preventing the program from exiting because it was not marked as a daemon thread. This fix marks the thread as daemon so the program can exit normally after the pipeline completes. Based on the suggested fix in issue com-lihaoyi#417 by JaredNeil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #417: os.proc.pipeTo causes program to never exit
Problem
The broken pipe handler thread was not marked as a daemon thread, which prevented the program from exiting after the pipeline completed.
Solution
Mark the broken pipe handler thread as a daemon thread so the JVM can exit normally.
Testing
This fix allows the program to exit normally after the pipeline completes, as demonstrated in the issue.
Related