Fix projected dip-means#114
Open
anripa wants to merge 1 commit into
Open
Conversation
This commit changes the logic for selecting the cluster for splitting. The code was change from picking the lowest score (p-value) to picking the maximum dip statistic. This matches the original paper algorithm description (see the reference below). The additional benefit is that the p-value can be exactly zero for two very large dip values, hence the selection would be random. Chamalis, T., & Likas, A. (2018). The Projected Dip-means Clustering Algorithm. Proceedings of the 10th Hellenic Conference on Artificial Intelligence, SETN ’18, 1–7. https://doi.org/10.1145/3200947.3201008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the logic for selecting the cluster for splitting. The code was change from picking the lowest score (p-value) to picking the maximum dip statistic. This matches the original paper algorithm description (see the reference below). The additional benefit is that the p-value can be exactly zero for two very large dip values, hence the selection would be random.
Chamalis, T., & Likas, A. (2018). The Projected Dip-means Clustering Algorithm. Proceedings of the 10th Hellenic Conference on Artificial Intelligence, SETN ’18, 1–7. https://doi.org/10.1145/3200947.3201008