Fix PG-means#112
Merged
Merged
Conversation
- select the largest log likelihood model when updating (instead of lowest) - use log likelihood for comparing models instead of the lower bound - improve new center proposal by picking the lowest log likelihood points - fix possible bias in random projections by using randn instead of rand - scale critical value if downsampling data
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 92.80% 92.85% +0.04%
==========================================
Files 63 63
Lines 9135 9232 +97
==========================================
+ Hits 8478 8572 +94
- Misses 657 660 +3
🚀 New features to boost your workflow:
|
collinleiber
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are made to fix the logic or to improve it: