Repository navigation
feat(datacomparison): reference a column by tag DEV-231852 - #26
Merged
Merged
Conversation
Add EntityTypeColumnReferenceByTag with optional TagKey and TagValue fields on Reference. Validate requires TagKey for the new type. Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
TimmersThomas
marked this pull request as ready for review
November 5, 2026 12:10
TimmersThomas
enabled auto-merge
November 5, 2026 12:26
Document the tag reference in the language grammar, add a YAML round-trip test and fold the tag Accept test into the existing table. gopkg.in/yaml.v3 becomes a direct dependency for the test. Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
|
rmennes
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntityTypeColumnReferenceByTagondatacomparison.Reference, with optionalTagKey/TagValuefields (json/yaml/gqlgentagKey,tagValue).Validate()returnsErrTagKeyRequiredwhen the entity type isColumnReferenceByTagandTagKeyis empty. An emptyTagValuemeans any value for the key.languagegrammar documents the new reference form.Existing visitors keep working:
Acceptstill callsVisitor.Literal, so a visitor that does not support the new type decides how to fail on it.Test plan
go test -race -mod=readonly ./...passes (JSON and YAML round-trips, validation, enum string/parse, visitor accept)go generate ./datacomparisonleaves the generated files unchangedgolangci-lint run ./...reports 0 issuesbd91586until then, and moves to the release tag afterwards. Pushing the review commit changed this branch's head away frombd91586, which is fine because that commit stays reachable through this PR's history🤖 Generated with Claude Code