DRYD-2018: Search > New > Search and relate/report dialogs should show new form if chosen #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
The updates include:
useNewSearchfrom redux to theSearchFormcomponent, so that we don't always show the classic form, but the one user has selected.searchToSelectstore when new form is being used.searchConditionbased on theuseNewSearchvalue.Why are we doing this? (with JIRA link)
Showing always the classic form in the search-to-select modal dialogs is confusing, when user has chosen to use the new search form: https://collectionspace.atlassian.net/browse/DRYD-2018
How should this be tested? Do these changes have associated tests?
The search to select modal dialog is shown in the search and relate funnel and in the report funnel.
For search and relate:
For search and report:
Please test following functionality of Search Form in both dialogs:
Dependencies for merging? Releasing to production?
No dependencies
Has the application documentation been updated for these changes?
We need to update the documentation accordingly before the final release
Did someone actually run this code to verify it works?
@spirosdi ran this locally
Have any new accessibility violations been handled?
No new accessibility violations