Skip to content

Conversation

@spirosdi
Copy link
Contributor

@spirosdi spirosdi commented Jan 30, 2026

What does this do?
The updates include:

  • passing useNewSearch from redux to the SearchForm component, so that we don't always show the classic form, but the one user has selected.
  • creating and passing reducers, selectors to update/retrieve data from searchToSelect store when new form is being used.
  • conditionally setting searchCondition based on the useNewSearch value.

Why are we doing this? (with JIRA link)
Showing always the classic form in the search-to-select modal dialogs is confusing, when user has chosen to use the new search form: https://collectionspace.atlassian.net/browse/DRYD-2018

How should this be tested? Do these changes have associated tests?
The search to select modal dialog is shown in the search and relate funnel and in the report funnel.
For search and relate:

  1. Search for Objects
  2. Select some Objects from the results
  3. Click the "Relate" button
  4. The search form is being displayed in the dialog

For search and report:

  1. Go to Tools -> Reports
  2. Select a Report that runs on "Record List" or "Single Record"
  3. Click the "Run" button
  4. Select to run the Report on a "record list" or a "single record"
  5. Click the "Select" button
  6. The search form is being displayed in the dialog

Please test following functionality of Search Form in both dialogs:

  • Form shown in the dialog is the one user selected in the /search page
  • When using new search form:
    • Form is shown initially empty
    • Field options are populated according to the record type selected in the "Find" option
    • Clicking "Clear" button, clears the whole form
    • Creating a search condition and searching, works as expected
    • Clicking "revise search" in the results view, shows the form prefilled

Dependencies for merging? Releasing to production?
No dependencies

Has the application documentation been updated for these changes?
We need to update the documentation accordingly before the final release

Did someone actually run this code to verify it works?
@spirosdi ran this locally

Have any new accessibility violations been handled?
No new accessibility violations

@spirosdi spirosdi requested a review from mikejritter January 30, 2026 16:31
@spirosdi spirosdi marked this pull request as draft January 30, 2026 16:36
@spirosdi spirosdi marked this pull request as ready for review January 30, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants