Repository navigation
Conversation
boxerab
requested changes
Oct 29, 2026
boxerab
left a comment
Collaborator
There was a problem hiding this comment.
thanks, exposing vad on the rest endpoint is useful. two things change behaviour for existing callers though:
condition_on_previous_textnow defaults toFalse.WhisperModel.transcribedefaults it toTrueand the endpoint never overrode it, so every request that doesn't send the field would decode differently.- the vad defaults (0.6 / 500 / 800 / 200) don't match faster-whisper's
VadOptions(0.5 / 0 / 2000 / 400) or the websocket path ({"threshold": 0.5}).
could you default the new fields to None and only pass the ones the client set? then the defaults stay in faster-whisper.
smaller:
- the same kwargs are built twice, one dict passed to both paths would fix that and also lets the streaming path pick up
hotwords, which it drops today. vad_filteris passed to_stream_transcriptionby position, please pass it by name like the rest.- please add a line to the readme next to the
hotwordsrest field, and a test that the form fields reachtranscriber.transcribeand that a request without them keeps the current arguments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.