Add PD2 damage calculator by ChaseBianchi · Pull Request #26 · coleestrin/pd2-tools

ChaseBianchi · 2026-05-26T18:44:23Z

Summary

Adds the Project Diablo 2 damage calculator feature with full-page and condensed character-page calculator experiences.
Sources damage mechanics from explicit PD2 extracted game tables instead of hidden local/generated comparison data.
Adds selectable weapons, skills, transformations, multiple auras with self/party handling, and calculator cache/type support.
Adds feature-focused tests and documentation for the PD2 game-file source-of-truth workflow.
Adds docs/runbooks/ with runbooks for all source scripts, including repeatable commands for api/src/scripts/damage-stress-test.ts.
Add AGENTS.md, with a pointer to relevant docs.

Verification

npm run lint (api)
npm run build (api)
npm test -- damage-calculator.test.ts --runInBand (api)
npm test -- routes.test.ts --runInBand (api)
npm run lint (web)
npm run build (web)
docker compose up -d --build
Local smoke checks for ChaseWoof and Sinfection calculator data

Notes

Full host-side API test suite still requires a reachable local PostgreSQL instance on localhost:5432 for existing DB-backed tests.
Local Docker use requires current-season PD2 text tables via PD2_EXTRACT_HOST_DIR or api/.pd2-live-extract.

Testing

in addition to the test files, I ran several stress tests by manually running src/scripts/damage-stress-test.ts

Metric	Value
Live characters requested/fetched/processed	600 / 600 / 600
Failed	0
Unsupported	0
Profiles generated	644,003
Damage components generated	2,510,139
Profiles with no components	0
Components missing source refs	0
Avg / p95 / p99 per character	346.94ms / 766ms / 1,210ms
Max per character	4,011ms

Screenshots

Desktop

Mobile

Mini-calc on character page

Risks

In my local environment the auto-generated ads were pretty experience breaking. It would often run a full page video ad below the character selection of the damage-calculator page. It will also sometimes put an add in the middle of the Damage Calculator section beneath the skills/aura selection. Not sure how ads are being handled though, so I didn't address it.

coleestrin · 2026-06-02T00:55:12Z

is there a reason for these changes? this and to adding the multiple cors origins to the env? did you run into issues?

This was added to make local dev across Vite/preview ports easier, not important so ill remove it.

coleestrin · 2026-06-02T01:00:57Z

id rather just have the .txt files committed rather than doing all this with the script to extract them, they can just be manually extracted w/ the mpq extractor that comes with pd2 and then just changed once per season

as it assumes wherever its run has pd2 installed which is not the case in production

Changed to having the game files in the repo and a brief doc on how to update those files

coleestrin · 2026-06-02T01:01:24Z

don't believe this is needed given my other requested changes

coleestrin · 2026-06-02T01:01:37Z

this can be removed from the pr

coleestrin · 2026-06-02T01:01:58Z

see my comment about cors and the other comment about txt files

coleestrin · 2026-06-02T01:08:39Z

not needed in pr

coleestrin · 2026-06-02T01:08:54Z

not needed in pr as per my requeseted changes

coleestrin · 2026-06-02T01:09:22Z

not needed in pr

coleestrin · 2026-06-02T01:10:15Z

  });

  describe("Complex Scenarios", () => {
+    it("should apply ChaseWoof-style Druid skill bonuses from equipped items and inventory charms", () => {


remove "chasewoof-style"

coleestrin · 2026-06-02T01:12:58Z

is this and the other scripts in this folder still meaningful or were they just for your initial testing and research?

It can live locally

coleestrin

re: discord comments, I think i'd prefer to have the stress test script and docs/runbooks folder kept locally on your end, you can just remove them the pr and keep them locally for your future development

coleestrin · 2026-06-04T22:24:26Z

+  violet: "var(--mantine-color-violet-5)",
+  gray: "var(--mantine-color-gray-5)",
+  white: "var(--mantine-color-white)",
+  physical: "var(--mantine-color-pd2Physical-5)",


physical, combinedDamage, and bugReport shouldn't have their own theme colors here, it should be just the core theme colors e.g. red, why do those 3 specific attributes need their own tuple of colors?

Just to distinguish damage types on the calculator with their own color.

The bug report button was a design choice to have a secondary button color.

id rather place the physical and combineddamage in stat-colors.ts just with the hex there and i think the bug button color if you're not using red or a different standard color i think it'd be better to just put the color inline in the button styles rather than having it here.

coleestrin · 2026-06-04T22:32:35Z

 }));
 export const SEASON_STORAGE_KEY_SUFFIX = `s${CURRENT_SEASON}`;
 export const LEVEL_RANGE_COOKIE_KEY = `levelRange_${CURRENT_SEASON}`;
+export const DAMAGE_CALCULATOR_PAYLOAD_VERSION = "damage-model-v10";


purpose of tracking this?

Cache busting for updates

coleestrin · 2026-06-04T22:38:57Z

+export * from "./damage";
+
+// Extended character types
+export * from "./extended-character";


why do we need this? if we are adding the damage prop to every character response i don't think we'd need this special type since every character would have this so we can just add the damage prop to whatever the current character type is.

I think the original idea was separation of concerns, but yeah agree it's simplified by integrating into existing response.

coleestrin · 2026-06-06T17:23:57Z

@@ -0,0 +1,40 @@
+import fs from "fs";


is this file not needed anymore since we aren't doing the extraction in the repo anymore?

coleestrin · 2026-06-06T18:01:33Z

The damage model notes dropdown is not very readable to the average user, maybe handwrite some of those (at least the 2nd line to make it more clear?) to make it more readable or understandable to the average user who will be using it? Also we can include a disclaimer there stating it may not be 100% exact and that if you notice significant deviations from the damage you expect, to file a bug report (with a link to the discord)

coleestrin · 2026-06-06T18:06:17Z

On the character page the damage calculator button should open in new tab. Similarly on the damage calculator page, clicking to open the character should open in a new tab as well.
Season dropdown has "Latest" but also includes "season 13" in the list (duplicate)

coleestrin · 2026-06-06T18:09:07Z

Does it support bows? The "Weapon" dropdown shows as unarmed for characters with bows.

coleestrin · 2026-06-06T18:09:50Z

And thank you again for all your work, this is excellent.

ChaseBianchi marked this pull request as ready for review May 26, 2026 19:22

coleestrin requested changes Jun 2, 2026

View reviewed changes

ChaseBianchi requested a review from coleestrin June 2, 2026 03:26

ChaseBianchi force-pushed the feature/damage-calculator branch from 76eaf23 to 6a0c69e Compare June 2, 2026 12:47

coleestrin requested changes Jun 4, 2026

View reviewed changes

ChaseBianchi requested a review from coleestrin June 5, 2026 14:07

coleestrin reviewed Jun 6, 2026

View reviewed changes

Comment thread api/src/jobs/character-scraper.ts Outdated

coleestrin reviewed Jun 6, 2026

View reviewed changes

Comment thread web/src/components/character/StatsSection.tsx

ChaseBianchi requested a review from coleestrin June 9, 2026 13:37

ChaseBianchi force-pushed the feature/damage-calculator branch 2 times, most recently from ad11ec3 to e882b0b Compare June 18, 2026 00:47

Add damage calculator feature

6e45be6

ChaseBianchi force-pushed the feature/damage-calculator branch from e882b0b to 6e45be6 Compare June 18, 2026 13:58

coleestrin approved these changes Jun 18, 2026

View reviewed changes

coleestrin merged commit 6a8a580 into coleestrin:main Jun 19, 2026
2 checks passed

Conversation

ChaseBianchi commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Notes

Testing

Screenshots

Risks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coleestrin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coleestrin Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coleestrin Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coleestrin commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coleestrin commented Jun 6, 2026

Uh oh!

coleestrin commented Jun 6, 2026

Uh oh!

coleestrin commented Jun 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

ChaseBianchi commented May 26, 2026 •

edited

Loading

coleestrin Jun 6, 2026 •

edited

Loading

coleestrin Jun 6, 2026 •

edited

Loading

coleestrin commented Jun 6, 2026 •

edited

Loading