Repository navigation
fix: unify window button sizes and use per-style caption icons - #283
Merged
Merged
Conversation
The close glyph defaulted to 16 while minimize/maximize used 12, so it looked larger than its neighbours. All window buttons are now 40x40 with 16 icons, matching the sidebar tool buttons. Dialog title bars grow from 40 to 48 (and CaptionHeight with them) so the round close button no longer touches the top edge; DiskContentDialog's fixed height grows by the same 8 px. Caption glyphs and colours now come from the current style: style B uses rounder glyphs in amber/green/red, style C keeps the thin monochrome set. The maximize/restore glyph switch moves from code-behind into a WindowState trigger so it follows style changes, and the close glyph turns white on its red hover. PaletteKeysTests covers the new keys.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CaptionHeightupdated inDialogWindowBase,DiskContentDialogandSpaceUsageDialog) so the round close button no longer touches the top edge.DiskContentDialog's fixed height grows from 480 to 488 to keep its content area unchanged.WindowGlyph*(AppStyle.A/B) andWindowIcon*(B and C palettes).WindowStatetrigger, so it follows style changes. The close glyph turns white on its red hover state.Test plan
dotnet build(0 warnings, 0 errors)dotnet test tests/ManagedDrive.Tests(2367 passed);PaletteKeysTestsnow covers the new palette and glyph keys