Repository navigation
feat: add Traditional Chinese (zh-TW) UI and installer language - #75
Merged
Merged
Conversation
Add a zh-TW string table and a ZhTW language choice. Auto now picks Traditional Chinese for zh-TW, zh-HK, zh-MO and Hant systems (an explicit Hans script still wins), uses Traditional CJK fallback fonts, and treats both Chinese languages alike for the default base currency.
Use the official ChineseTraditional.isl shipped with Inno Setup 7.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zh-TW.jsonstring table (including data source names and option texts), aZhTWlanguage choice in settings, and Traditional CJK fallback fonts (Microsoft JhengHei UI / PingFang TC / Noto Sans CJK TC).Autonow resolveszh-TW,zh-HK,zh-MOandHantsystems to Traditional Chinese; other Chinese systems stay Simplified, and an explicitHansscript wins over the region (zh-Hans-HKis Simplified).Loc.IsChinese).ChineseTraditional.islto the Inno Setup installer. It ships with Inno Setup 7, which the release workflow already uses, so no workflow change is needed.README.zh-TW.md, link it from the other READMEs, and update the localization notes inCLAUDE.mdanddocs/ADDING_A_PROVIDER.md.Notes
Provider_*/Option_*keys must exist in both Chinese tables; a missing one falls back to English, not to the other Chinese file. A test requires the two tables to have the same keys.zh-TW.jsonwording is converted from the Simplified table and would benefit from a review by a native Taiwan speaker (for example持倉).README.zh-TW.mdreuses the Simplified screenshots.Test plan
dotnet build FluxTick.slnxdotnet test --solution FluxTick.slnx(all passing)installer/FluxTick.isswith Inno Setup 7