Repository navigation
feat(ui): show the range change beside the reference change - #73
Merged
Merged
Conversation
The headline change on the card is always measured against the reference price of the source, named by its basis (previous close or 24h ago). The change over the chart range is a figure of its own next to the range start. The rows now take the range from the snapshot timeline instead of their own copy of the chart range, and the service keeps the chart as it was while the history of a newly chosen range loads, so it does not fall back to the last hour in between.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SparklineTimeline.Range) instead of keeping their own copy, so the texts always name the range the prices are really of. The timeline constructor rejects a range whose window does not match.MarketDataServicekeeps the chart as it was instead of falling back to the last hour. The hold ends when the history arrives, the loads give up, the source loses the range, or the deadline passes.Test plan
dotnet build FluxTick.slnxdotnet test --project tests/FluxTick.Core.Testsdotnet test --project tests/FluxTick.App.Tests