Add sphere generator#1
Open
colspan wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for sharing the great work for the Python based lithophane model generator.
I added a sphere generator for this library.
An example of sphere generation is also available.
The sphere lithophane fit together well with spherical images taken by 360 degree cameras.
The following example was generated by a spherical image taken by Ricoh Theta.
I had to add
makeMeshSpherebecause the inner-back of the model must be also sphere.I chose camelCase rule for this method though the original
makemeshwas not.So I would ask this rule and I'll follow discussions and suggestions.