Repository navigation
Conversation
a-d-j-i
force-pushed
the
feat/redirect-handling
branch
from
October 16, 2026 18:05
dfc66b2 to
523d34a
Compare
a-d-j-i
force-pushed
the
feat/redirect-handling
branch
from
October 16, 2026 18:59
523d34a to
20b1632
Compare
a-d-j-i
marked this pull request as ready for review
October 19, 2026 12:20
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
emiliorizzo
self-requested a review
October 19, 2026 15:46
emiliorizzo
previously approved these changes
Oct 19, 2026
a-d-j-i
added this pull request to stack #54
October 20, 2026 16:46
a-d-j-i
dismissed
emiliorizzo’s stale review
October 20, 2026 16:46
The merge-base changed after approval.
a-d-j-i
force-pushed
the
feat/redirect-handling
branch
from
October 20, 2026 16:56
ad9decf to
cae35d0
Compare
a-d-j-i
force-pushed
the
feat/redirect-handling
branch
from
October 21, 2026 22:28
cae35d0 to
f6f6623
Compare
Keys manifest lookup by response.url for followed redirects: response-wrapper carries url + redirected; resolveManifestKey prefers response.url when non-empty and falls back to req.url for opaque-redirect and script-constructed Response. Fixes same-origin subresource redirects turning into NOT_FOUND. Adds sw-redirects.spec.ts covering server-issued redirect handling. Lands docs/redirect-handling.md with the redirect issues and our plan. Adds child-SW probe routes in sw_app.js (manual/follow/error/respond-302/ respond-302-ext/add-headers/post) and sw-child-fetch.spec.ts covering redirect-mode overrides, headers/method tampering, synthesized 3xx (internal + cross-origin), and the server-302 escape-to-attacker gap. Plus a POC browser-platform probe pinning that SW-materialized 302 at <script> is followed by the browser. createRedirectResponse now takes a status arg (301/302/303/307/308) with matching constant + fetch-handler + storage touch-ups. No functional change yet to shouldSkipVerification or the manifest schema.
Forcing-function fix for cross-origin redirect verification: devs declare every allowed redirect source in a signed `manifest.redirects`, DF synthesizes the response from the manifest and ignores whatever Location the server/child-SW provided. Undeclared sources block.
a-d-j-i
force-pushed
the
feat/redirect-handling
branch
from
October 22, 2026 21:43
f6f6623 to
35dc9f9
Compare
a-d-j-i
removed this pull request from stack #54
October 22, 2026 21:43
a-d-j-i
changed the base branch from
ui/warning-page-view-dispatch
to
feat/warning-view-infra
October 22, 2026 21:44
a-d-j-i
added this pull request to stack #66
October 22, 2026 21:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keys manifest lookup by response.url for followed redirects: response-wrapper carries url + redirected; resolveManifestKey prefers response.url when non-empty and falls back to req.url for opaque-redirect and script-constructed Response. Fixes same-origin subresource redirects turning into NOT_FOUND. Adds sw-redirects.spec.ts covering server-issued redirect handling.
Lands docs/redirect-handling.md with the redirect issues and our plan.
Adds child-SW probe routes in sw_app.js (manual/follow/error/respond-302/ respond-302-ext/add-headers/post) and sw-child-fetch.spec.ts covering redirect-mode overrides, headers/method tampering, synthesized 3xx (internal + cross-origin), and the server-302 escape-to-attacker gap. Plus a POC browser-platform probe pinning that SW-materialized 302 at <script> is followed by the browser.
createRedirectResponse now takes a status arg (301/302/303/307/308) with matching constant + fetch-handler + storage touch-ups. No functional change yet to shouldSkipVerification or the manifest schema.