Skip to content

feat(core): group blocks on the warning page by failure type - #55

Open
a-d-j-i wants to merge 1 commit into
feat/signer-identity-tofufrom
ui/warning-page-view-dispatch
Open

a-d-j-i wants to merge 1 commit into
feat/signer-identity-tofufrom
ui/warning-page-view-dispatch

Conversation

@a-d-j-i

@a-d-j-i a-d-j-i commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Improve UI, add support for blocking reasons.
Add a script to be able to check the UI directly.

@a-d-j-i
a-d-j-i requested a review from a team as a code owner October 9, 2026 22:23
@a-d-j-i
a-d-j-i force-pushed the ui/warning-page-view-dispatch branch from b55cd05 to f516492 Compare October 9, 2026 22:48
@a-d-j-i
a-d-j-i added this pull request to stack #54 October 9, 2026 23:21
@a-d-j-i
a-d-j-i force-pushed the ui/warning-page-view-dispatch branch 3 times, most recently from 8cd051a to 1b67a18 Compare October 13, 2026 13:32
emiliorizzo
emiliorizzo previously approved these changes Oct 14, 2026
@a-d-j-i
a-d-j-i force-pushed the ui/warning-page-view-dispatch branch from 1b67a18 to fe1996d Compare October 16, 2026 12:39
@a-d-j-i
a-d-j-i force-pushed the ui/warning-page-view-dispatch branch from fe1996d to 01e328b Compare October 16, 2026 17:43
@a-d-j-i
a-d-j-i force-pushed the ui/warning-page-view-dispatch branch from 01e328b to edd92a6 Compare October 16, 2026 18:57
emiliorizzo
emiliorizzo previously approved these changes Oct 19, 2026
@a-d-j-i
a-d-j-i dismissed emiliorizzo’s stale review October 19, 2026 16:47

The merge-base changed after approval.

@a-d-j-i
a-d-j-i force-pushed the ui/warning-page-view-dispatch branch 2 times, most recently from 8120f28 to eebb342 Compare October 20, 2026 11:01
Mirrors the security-warning layout: separate .html / .css files under
src/templates/, loaded via Vite ?raw import, with a thin builder that
splices in the CSS and (optionally) a nonce. Builder moves from
src/core/ to src/client/ since sw-registration is its only consumer.

In packages/test-app, merges the warning preview with a new emergency
preview into src/preview-panel.js, served from with a small index
page linking to both. npm script: preview-panels.
@a-d-j-i
a-d-j-i force-pushed the ui/warning-page-view-dispatch branch from eebb342 to 5190a0e Compare October 20, 2026 16:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants