Fix AI review and comparison runtime - #17
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Production Vercel logs showed that OpenAI successfully returned
200 OKfor recommendation reviews, but the structured JSON was truncated by the sharedAI_MAX_OUTPUT_TOKENS=400setting. Every review then failed JSON parsing and fell back to the rules-based result.The comparison chatbot endpoint also had successful production requests, but new button clicks were not reaching the endpoint. The deployed HTML contained the button while browsers could continue using the older unversioned
chatbot.js, which had no handler for it.What changed
User impact
AI-assisted reviews can now complete their strict JSON response instead of displaying the generic unavailable message. The “Compare alternatives with AI” button will load the current JavaScript handler and send its question to the chatbot.
The deterministic recommendation remains available if a genuine provider failure occurs.
Validation
python -m pytest -q tests/— 132 passednode --check public/static/js/chatbot.js— passedgit diff --check— passed