Ati/cl 268 add date picker#43
Open
ati7697 wants to merge 3 commits into
Open
Conversation
Composes Popover, Calendar, and Button into a single component with a DateValue v-model, matching the SimpleSelect wrapper pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
DatePickercomponent to Gooey — a single-component wrapper composing the existingPopover,Calendar, andButtonprimitives with aDateValuev-model. shadcn-vue does not ship a CLI-installable date picker; the upstream docs describe it as a documented composition, so this follows theSimpleSelectcustom-wrapper pattern.src/components/date-picker/—DatePicker.vue(composition +DateFormatterlabel,disabledprop,placeholderprop,localeprop defaulting toen-AU),index.ts, Cypress smoke specapp/pages/components/DatePicker.vue— showcase with Basic + Disabled examplessrc/index.ts,app/pages/index.ts,app/router/index.ts, andapp/router/navigation.ts(sidebar — Forms group, between Checkbox and Field)2.3.3anddist/rebuiltAnything the reviewer needs to know
@internationalized/dateandlucide-vue-nextare already pulled in byCalendar/ used across the library.src/index.tsbut the route entry does not setshadcn: true(it's a custom composition, likeSimpleSelect/ConfirmDialog).defineModel<DateValue>()is used for v-model — matches the typeCalendaralready accepts, so values flow through unchanged if you swap a bareCalendarfor aDatePicker.Test plan
npm run dev→ visit/components/date-picker; click the trigger, pick a date, confirm the trigger label updates and the "Selected" line reflects the valuenpm run test(Cypress) — smoke spec passesnpm run buildsucceeds🤖 Generated with Claude Code