Remove special case notifying post author of threads#1548
Open
trichoplax wants to merge 51 commits intodevelopfrom
Open
Remove special case notifying post author of threads#1548trichoplax wants to merge 51 commits intodevelopfrom
trichoplax wants to merge 51 commits intodevelopfrom
Conversation
Instead of special casing creating a notification, we just have them follow normally automatically.
Remove special case notifying author of threads. This merge takes the changes so far from MoshiKoi's fork to a new branch `MoshiKoi/1025/remove-special-case-notifying-author-of-threads` in the `qpixel` repo. This will allow any qpixel developer access to continue work on this new branch and make a new pull request into `develop`.
…ng-author-of-threads
…ng-author-of-threads
…ng-author-of-threads
…hreads' of github.com:codidact/qpixel into MoshiKoi/1025/remove-special-case-notifying-author-of-threads
Now that pull request 1548 makes post author notification of new threads part of the standard post following rather than an author-specific special case, the author needs to be a follower of the post in the test fixtures to prevent a test failing. The test is: test/controllers/comments_controller_test.rb 'Should create new thread' Line 18
This was referenced Mar 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ng-author-of-threads
…ng-author-of-threads
…ng-author-of-threads
…ng-author-of-threads
…ng-author-of-threads
…ng-author-of-threads
…ng-author-of-threads
ArtOfCode-
approved these changes
Aug 21, 2025
Contributor
Author
|
Note that there is a suggested migration approach in a comment on the original version of this pull request, which will need to be added to this new pull request before merging. I haven't implemented this migration yet because it needs to come after the migration in #1920 so I'll wait until any changes requested during its review to ensure this one is dated later than that one. |
trichoplax
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request continues from #1037 that was from MoshiKoi's fork. It's now a branch on the QPixel repo to allow any QPixel developer to work on it. See the discussion on that previous pull request.
Fixes #1025.