Repository navigation
Conversation
codewhale-hq#6971 fixed two tests whose NO_PROXY=* guard did not cover their 127.0.0.1 fixture: the proxy matcher applies `*` to host names only and checks an IP literal against the address entries alone. The same guard is in other tests. Behind a local proxy that forwards to loopback they still pass, which is why only two showed up there. Behind one that does not (HTTP_PROXY and HTTPS_PROXY pointing at a closed port, NO_PROXY=localhost,127.0.0.1,::1 in the environment) twenty tests fail on main that pass without the proxy variables. Each replaces a NO_PROXY that already exempted its fixture with one that does not. Fifteen of them now set `*,127.0.0.1`: the wildcard stays for host names and the fixture's address is added. The other five are in mcp/oauth.rs, which this change leaves alone. Two guards in mcp/http_client.rs also stay as they are; their tests pass behind the same proxy. Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
github-actions
Bot
added
the
contribution-gate
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Thank you @Lstarsky0 for finding fifteen more loopback fixtures where the proxy matcher needs an explicit127.0.0.1 bypass. Your PR is now merged as your own work at 8aeeff6d, with your original commit and source branch retained, for0.10.2. The release has not shipped. The assertions, deadlines, locks and environment restoration remain unchanged. All fifteen changed fixtures and owner recovery passed on macOS, Ubuntu and Windows. Actual summaries: macOS retry19,035passed/0failed/33skipped; original Ubuntu19,032/0/34; original Windows18,301passed(including the existing browser-launcher leak)/0failed/27skipped. Ubuntu/Windows/Lint were not rerun in the retry. The first macOS job hit its165-minute deadline with only partial output; that cancelled record is retained. Final combined-candidate and packaged acceptance still need their own proof. |
Integrate main3929bcee after own-PR merges #6967, #6974, #6975 and #6966. Preserve stronger matching steer receipt, HTTP projection and identity assertions; retain one contributor provider-table auth marker in the atomic save. Keep all15 loopback guards and three independent/event watchdog corrections. Credit @Lstarsky0 and @gaord in release notes; original authored commits and source branches are preserved. Actual frozen macOS default-feature result: Summary [ 1.439s] 23 tests run: 23 passed, 15288 skipped All23 unique result ordinals are PASS. npm:540 Node +772 Vitest passed;0 failed;7 skipped. npm run check:web, versions, changelog sync, fmt and diff passed. Source hashes unchanged throughout. Existing __eh_frame linker warning retained. No new product test functions/comments or gate waivers. Old failed/cancelled CI evidence remains; complete new-head hosted CI/Windows owner recovery and final packages are pending. No provider inference or release/publication. Refs #6968 Refs #6972
What and why
Follow-up to #6971. That one fixed the two tests that fail behind a local proxy which forwards to loopback. This one covers the rest of the same guard, which only shows up behind a proxy that does not.
The setup:
HTTP_PROXYandHTTPS_PROXYpoint at a proxy that will not reach loopback (I used a closed port), and the environment already hasNO_PROXY=localhost,127.0.0.1,::1. On main, 20 tests fail there that pass without the proxy variables. Each of them setsNO_PROXY=*, which replaces a value that exempted its127.0.0.1fixture with one that does not: the matcher applies*to host names only.15 of the 20 now set
*,127.0.0.1. The wildcard stays for host names, and the fixture's address is added, so nothing that*exempted before is proxied now.mcp/http_client.rs: 6mcp/tests.rs: 3mcp/sse.rs: 2runtime_api/tests.rs: 2tui/ui/tests.rs: 2Left alone:
mcp/oauth.rs. They need the same one-value change, but that file is auth code, so I did not touch it.mcp/http_client.rs(shared_mcp_send_revalidates_after_client_selection_before_first_writeandprivate_dns_requires_an_explicit_operator_opt_in) keep*. Both tests pass behind the same proxy.Issue
No-Issue: follow-up to #6971, no issue filed for it
How I tested it
cargo nextest run -p codewhale-tui --libbehind the strict proxy described above: main (39f0733) fails 62 tests, this branch 47. The 15 that moved are the ones changed here, and nothing new fails. Of the 47, 42 also fail without any proxy on my machine (most need an extension-host Node version I don't have) and 5 are themcp/oauth.rsones.NO_PROXY, only the lowercase proxy variables set (closed port), and no proxy variables at all.cargo fmt --all -- --check,cargo clippy -p codewhale-tui --all-targets --all-featureswith CI's flags, andcargo check -p codewhale-tui --all-targets: clean. Clippy also on 1.99, pluscargo +1.89.0 check -p codewhale-tui.cargo nextest run -p codewhale-tui --libin my normal shell: 15244 passed, 42 failed, the same 42 as main.No new tests; this changes one value in fifteen existing ones.
Checklist
maincargo fmt --allpasses, and tests cover new or changed behaviordocs/features.toml(cargo test -p codewhale-tui --test feature_registrychecks it) — n/a