Skip to content

feat: improve configuration validation handling in interactive mode#250

Open
OliverTrautvetter wants to merge 8 commits intomainfrom
update_install_config_validation
Open

feat: improve configuration validation handling in interactive mode#250
OliverTrautvetter wants to merge 8 commits intomainfrom
update_install_config_validation

Conversation

@OliverTrautvetter
Copy link
Member

@OliverTrautvetter OliverTrautvetter commented Mar 19, 2026

Don't stop the interactive config generation because of a single wrong value.

Clickup

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the oms init install-config interactive workflow so configuration validation failures do not abort file generation, aligning with the goal of allowing users to correct issues after generation.

Changes:

  • Treat ValidateInstallConfig() findings as non-blocking warnings in interactive mode while preserving hard-fail behavior in non-interactive mode.
  • Adjust success messaging to reflect when generation completed with validation warnings.
  • Add tests covering interactive “continue despite validation issues” and non-interactive “still fails” behavior.
  • Update NOTICE files for Kubernetes-related dependency version bumps (v0.35.2 → v0.35.3).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
cli/cmd/init_install_config.go Allows interactive init to continue past validation failures and surfaces warnings via CLI output.
cli/cmd/init_install_config_interactive_test.go Adds test coverage for interactive warning behavior and non-interactive failure behavior.
NOTICE Updates Kubernetes module versions/URLs in license notices.
internal/tmpl/NOTICE Mirrors NOTICE updates for the templated notice file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OliverTrautvetter OliverTrautvetter marked this pull request as ready for review March 20, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants