feat: improve configuration validation handling in interactive mode#250
Open
OliverTrautvetter wants to merge 8 commits intomainfrom
Open
feat: improve configuration validation handling in interactive mode#250OliverTrautvetter wants to merge 8 commits intomainfrom
OliverTrautvetter wants to merge 8 commits intomainfrom
Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the oms init install-config interactive workflow so configuration validation failures do not abort file generation, aligning with the goal of allowing users to correct issues after generation.
Changes:
- Treat
ValidateInstallConfig()findings as non-blocking warnings in interactive mode while preserving hard-fail behavior in non-interactive mode. - Adjust success messaging to reflect when generation completed with validation warnings.
- Add tests covering interactive “continue despite validation issues” and non-interactive “still fails” behavior.
- Update NOTICE files for Kubernetes-related dependency version bumps (v0.35.2 → v0.35.3).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cli/cmd/init_install_config.go |
Allows interactive init to continue past validation failures and surfaces warnings via CLI output. |
cli/cmd/init_install_config_interactive_test.go |
Adds test coverage for interactive warning behavior and non-interactive failure behavior. |
NOTICE |
Updates Kubernetes module versions/URLs in license notices. |
internal/tmpl/NOTICE |
Mirrors NOTICE updates for the templated notice file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't stop the interactive config generation because of a single wrong value.
Clickup