Open
Conversation
NautiluX
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the default GCP bootstrap infrastructure footprint and aligns installer profiles/resource overrides accordingly.
Changes:
- Shrink GCP bootstrap VM sizing and reduce Ceph node count (4 → 3), plus adjust Ceph disk sizing and workspace image pool defaults.
- Update installer profiles so production/minimal include monitoring defaults, and extend the “noRequests” resource profile to apply minimal request overrides for Loki components.
- Update Go module dependencies and NOTICE files for updated Kubernetes module versions.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/bootstrap/gcp/gcp.go |
Reduces VM definitions (sizes/counts) and updates install-config generation to match smaller infra footprint. |
internal/bootstrap/gcp/gcp_test.go |
Adjusts unit tests to reflect the reduced number of instances/Ceph nodes. |
internal/installer/config_manager_profile.go |
Changes profile defaults (monitoring enabled for prod/minimal; minimal datacenter name now matches dev) and ensures resource profile applies after monitoring config is set. |
internal/installer/resource_profiles.go |
Adds Loki override entries for the no-requests resource profile via a shared helper. |
internal/installer/config_manager_profile_test.go |
Updates expectations for new profile behavior (datacenter name + monitoring). |
cli/cmd/init_install_config_test.go |
Updates minimal profile datacenter-name expectation. |
cli/cmd/init_install_config_interactive_test.go |
Updates production profile expectation to include monitoring defaults. |
go.mod |
Promotes golang.org/x/oauth2 and go-github to direct requirements. |
NOTICE / internal/tmpl/NOTICE |
Bumps Kubernetes module entries from v0.35.2 to v0.35.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NautiluX
force-pushed
the
shrink-vms
branch
3 times, most recently
from
2d0e8bd to
bbea760
Compare
Signed-off-by: NautiluX <2600004+NautiluX@users.noreply.github.com>
joka134
approved these changes
Mar 20, 2026
| Entry("prod profile", "prod", false, "production"), | ||
| Entry("production profile", "production", false, "production"), | ||
| Entry("minimal profile", "minimal", false, "minimal"), | ||
| Entry("minimal profile", "minimal", false, "dev"), |
Member
There was a problem hiding this comment.
Why do we call the dc of minimal dev?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the infrastructure requirements for gcp-based test environments