ci: harden pre-merge checks and supply chain - #273
Conversation
- add CodeQL workflow (javascript-typescript + actions) for parity with the plugins repo security scanning - add commitlint job validating PR commits (Conventional Commits) - add npm audit job (high/critical severity gate) - set top-level least-privilege permissions and PR concurrency cancellation on the CI workflow - drop the redundant build in the test job (pretest already builds) - pin remaining release.yml actions to commit SHAs - track npm updates via dependabot Co-authored-by: Jack Granatowski <contact@codeslash.net>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR hardens GitHub Actions workflows and dependency management by adding workflow permissions and concurrency controls, introducing commit message and dependency audit validation jobs, pinning third-party actions to commit SHAs, removing npm caching from publish and release paths to prevent poisoning, and configuring weekly npm ecosystem checks via Dependabot. ChangesCI/CD Workflow Security and Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pre-empt the cache-poisoning class flagged by zizmor on the plugins repo: a poisoned dependency cache could be baked into the published GitHub Release assets or the CDN-served dist branch. These workflows now fetch dependencies fresh with integrity verification. CI keeps its cache.
|
@coderabbitai review |
✅ Action performedReview finished.
|
SLASHED already runs CodeQL via GitHub's default setup (configured in repo settings, no workflow file). An advanced workflow conflicts with it: the SARIF upload is rejected with "CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled", which was the only failing check on this PR. Remove the redundant workflow and keep relying on default setup for the framework's JS/Actions scanning.
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Summary
Strengthens the pre-merge gate and supply-chain posture of the framework CI, and brings it to parity with the SLASHED-Plugins repo.
javascript-typescript+actions), matching the plugins repo. Runs on push, PR, and weekly.permissions: contents: readand PR concurrency cancellation on the CI workflow.testjob (pretestalready builds before Playwright).release.ymlactions to commit SHAs (checkout, setup-node, action-gh-release) —ci.ymlwas already pinned.Testing
npm audit --audit-level=high→ 0 vulnerabilities.Notes
lint,build,test,artifacts-freshness,dependency-audit,commitlintand CodeQL as required status checks in branch protection.commitlintjob only runs onpull_requestevents (it needs a base..head range).Summary by CodeRabbit