feat(KasmVNC): allow share variable to be passed with default: owner
#709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed in scenarios where we want to give flexibility of sharing the Desktop Environment to demonstrate Desktop Application Demos.
matifali
approved these changes
Feb 10, 2026
Member
matifali
left a comment
matifali
left a comment
There was a problem hiding this comment.
Thank you. Please bump the minor version using the script, and it's good to merge.
./.github/scripts/version-bump.sh minor
Contributor
Author
|
Done |
Member
|
Once the CI passes, I can merge. Check the failed CI run: https://github.com/coder/registry/actions/runs/21852884352/job/63063359653?pr=709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small enhancement to KasmVNC module, This is needed in scenarios where we want to give flexibility of sharing the Desktop Environment to demonstrate Desktop Application Demos.
Type of Change
Module Information
Path:
registry/coder/modules/kasmvncNew version:
v1.0.0Breaking change: [ ] Yes [x] No
Template Information
Path:
registry/[namespace]/templates/[template-name]Testing & Validation
bun test)bun fmt)Related Issues
Code Server module already supports, so I had just copy-pasted that feature into here in this module.