-
Notifications
You must be signed in to change notification settings - Fork 65
🤖 fix: improve workspace default runtime UX #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+276
−44
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b644895
fix: improve workspace default runtime UX
ammar-agent dbb794d
fix: improve workspace default runtime UX
ammario 18023ff
🤖 fix: unify runtime option inputs and defaults button polish
ammar-agent 95b2bd4
🤖 fix: clear runtimes scope hint on settings navigation/close
ammar-agent 92e1461
🤖 fix: update workspace default runtime RFC notes
ammar-agent 6d2ad9d
RFC fixups
ammario File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --- | ||
| author: "@ammario" | ||
| date: 2026-02-23 | ||
| --- | ||
|
|
||
| # Workspace Default Runtime | ||
|
|
||
| Commit 88a2be88e2 moved the workspace default runtime config from a tooltip checkbox to a | ||
| dedicated sections page. It left the following outstanding UX gaps: | ||
|
|
||
| - Unclear path for user to set runtime config to default | ||
| - Unclear persistence behavior for runtime options | ||
|
|
||
|
|
||
| Two fixes are required: | ||
|
|
||
| - Make the `configure` runtime more prominent, and call it `set defaults` instead. | ||
| - Create distinct visual style when the current runtime options are not the default so the user | ||
| can more quickly see how they would persist their changes. Only the button itself should change, | ||
| and the re-style must not create a layout shift. | ||
| - Include runtime options in the new runtime settings page to clarify how the defaults work there. | ||
| - These defaults should be configurable just as they are in the new workspace page. | ||
| - The options should have labels to match parity with the new workspace page. | ||
|
|
||
| There's also a bug where clicking the configure button on a project page takes you to the | ||
| settings page with a global scope instead of the project scope. We should fix this as well. | ||
|
|
||
|
|
||
| ## Code Structure | ||
|
|
||
| During this change, it is imperative that we have single-ownership of: | ||
|
|
||
| - What options are available per runtime | ||
| - The setting / getting of defaults | ||
| - The list of runtime types | ||
| - Display code for the runtime options |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # RFC | ||
|
|
||
| This folder contains human-written but AI-assisted RFCs for implementing major work items in Mux. | ||
|
|
||
| It is an adjunct to AI planning but shifts content ownership to humans for more precise steering. | ||
|
|
||
| RFCs should be in files named `<YYYYMMDD>_<title>.md` in this folder. | ||
|
|
||
| The file should be structured as follows: | ||
|
|
||
| ```markdown | ||
| --- | ||
| author: @<github-username> | ||
| date: <YYYY-MM-DD> | ||
| --- | ||
|
|
||
| # <Title> | ||
|
|
||
| ... body ... | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import { useId } from "react"; | ||
|
|
||
| import { cn } from "@/common/lib/utils"; | ||
|
|
||
| /** | ||
| * Shared runtime option input used by creation and settings screens. | ||
| * Keeps labels/inputs visually and behaviorally aligned across both flows. | ||
| */ | ||
| export function RuntimeConfigInput(props: { | ||
| label: string; | ||
| value: string; | ||
| onChange: (value: string) => void; | ||
| placeholder: string; | ||
| disabled?: boolean; | ||
| hasError?: boolean; | ||
| id?: string; | ||
| ariaLabel?: string; | ||
| className?: string; | ||
| labelClassName?: string; | ||
| inputClassName?: string; | ||
| }) { | ||
| const autoId = useId(); | ||
| const inputId = props.id ?? autoId; | ||
|
|
||
| return ( | ||
| <div className={cn("flex items-center gap-2", props.className)}> | ||
| <label | ||
| htmlFor={inputId} | ||
| className={cn("text-muted-foreground text-xs", props.labelClassName)} | ||
| > | ||
| {props.label} | ||
| </label> | ||
| <input | ||
| id={inputId} | ||
| aria-label={props.ariaLabel ?? props.label} | ||
| type="text" | ||
| value={props.value} | ||
| onChange={(e) => props.onChange(e.target.value)} | ||
| placeholder={props.placeholder} | ||
| disabled={props.disabled} | ||
| className={cn( | ||
| "border-border-medium bg-background-secondary text-foreground placeholder:text-muted focus:border-accent h-7 rounded border px-2 text-xs focus:outline-none disabled:cursor-not-allowed disabled:opacity-50", | ||
| props.inputClassName, | ||
| props.hasError && "border-red-500" | ||
| )} | ||
| /> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.