Skip to content

Comments

🤖 fix: add Shift+M file-read hint in immersive review footer#2550

Merged
ibetitsmike merged 1 commit intomainfrom
mike/shortcuts-fd72
Feb 24, 2026
Merged

🤖 fix: add Shift+M file-read hint in immersive review footer#2550
ibetitsmike merged 1 commit intomainfrom
mike/shortcuts-fd72

Conversation

@ibetitsmike
Copy link
Contributor

@ibetitsmike ibetitsmike commented Feb 23, 2026

Summary

Keep existing Code Review shortcuts from main unchanged and improve discoverability by showing the file-level mark-as-read shortcut in immersive mode.

Background

  • main already supports file-level mark-as-read via Shift+M.
  • Rebinding shortcuts was no longer desired.
  • The remaining gap was discoverability in the immersive review footer.

Implementation

  • Rebased branch onto main and dropped shortcut remap changes.
  • Added a footer hint in ImmersiveReviewView for file-level read:
    • ⇧Mfile read
  • Left keybind behavior untouched (r hunk read, Shift+M file read, Cmd/Ctrl+R refresh).

Validation

  • make typecheck
  • make static-check

Risks

Low risk. This is a UI hint-only change with no shortcut behavior or handler logic modifications.


Generated with mux • Model: openai:gpt-5.3-codex • Thinking: xhigh • Cost: $0.96

@ibetitsmike
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ibetitsmike
Copy link
Contributor Author

@codex review

@ibetitsmike
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ibetitsmike
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 563801bfa0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ibetitsmike
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ibetitsmike ibetitsmike changed the title 🤖 fix: remap review file mark-as-read to R 🤖 fix: add Shift+M file-read hint in immersive review footer Feb 24, 2026
@ibetitsmike ibetitsmike added this pull request to the merge queue Feb 24, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 24, 2026
@ibetitsmike ibetitsmike added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 2eafff2 Feb 24, 2026
23 checks passed
@ibetitsmike ibetitsmike deleted the mike/shortcuts-fd72 branch February 24, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant