🤖 fix: auto-select full hunk when jumping with J/K#2549
🤖 fix: auto-select full hunk when jumping with J/K#2549ibetitsmike wants to merge 1 commit intomainfrom
Conversation
|
@codex review Please review this immersive review mode UI change. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43526d9f05
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/browser/components/RightSidebar/CodeReview/ImmersiveReviewView.tsx
Outdated
Show resolved
Hide resolved
ibetitsmike
force-pushed
the
mike/immersive-active-hunk-outline
branch
from
43526d9 to
97649db
Compare
|
@codex review Addressed the prior feedback:
|
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ibetitsmike
force-pushed
the
mike/immersive-active-hunk-outline
branch
from
97649db to
311c607
Compare
|
@codex review Addressed the inline-comments regression: active hunk outline now remains continuous through inline note/composer rows and bottom-edge placement accounts for post-line rows. |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ibetitsmike
force-pushed
the
mike/immersive-active-hunk-outline
branch
from
311c607 to
7d41dd9
Compare
ibetitsmike
changed the title
|
@codex review Updated per product direction: J/K hunk jumps now auto-select the entire target hunk range for immediate commenting; prior active-hunk-outline rendering changes were removed. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Summary
This PR updates immersive review hunk navigation so pressing
J/Kautomatically selects the full target hunk range after a successful hunk jump, making immediate comment actions operate on the whole hunk.Background
The previous iteration focused on outlining the active hunk, but that did not match the intended workflow. The goal is keyboard-first review speed: after jumping hunks with
J/K, the user should be ready to comment on the full hunk without manually selecting lines.Implementation
navigateHunkfromJ/K), store the target hunk ID and switch hunks.selectedLineRangeto the full hunk rangeValidation
make static-checkRisks
Low. The change is scoped to immersive review keyboard navigation state and does not affect backend APIs or persistence.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:338259{COSTS}