🤖 feat: add touch-first mobile immersive review entrypoint#2540
🤖 feat: add touch-first mobile immersive review entrypoint#2540ibetitsmike wants to merge 5 commits intomainfrom
Conversation
Add a mobile/touch-only workspace-header action that opens immersive code review in touch mode, and thread touch-specific naming/flags through the review overlay path so touch mode hides keyboard-only affordances and opens inline comment composer on row tap. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.00`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.00 -->
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a02ff4b37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/browser/components/RightSidebar/CodeReview/ImmersiveReviewView.tsx
Outdated
Show resolved
Hide resolved
Ensure touch-mode row taps only auto-open the add-comment composer when the tapped row resolves to a diff hunk, preventing comments from opening on a different fallback hunk line. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.00`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.00 -->
|
@codex review Addressed the touch-line composer fallback issue by opening touch auto-composer only when the tapped row resolves to a hunk-backed line. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a329fa538d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Restrict the mobile touch immersive review menu action to `(max-width: 768px) and (pointer: coarse)` so narrow desktop windows retain keyboard-first immersive behavior. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.00`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.00 -->
|
@codex review Addressed the coarse-pointer gating feedback by restricting the touch immersive menu path to |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
Added follow-up coverage in the latest commit:
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
Follow-up fix for Storybook stability is now pushed.
Local repro/validation:
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Summary
This adds a mobile/touch-specific entry point to immersive code review from the workspace header context menu, updates immersive review to run in a touch-first mode, and includes dedicated Storybook coverage for the iPhone 17 Pro Max touch immersive layout.
Background
On mobile screens, the existing immersive review flow was discoverable from keyboard-oriented controls and still showed desktop keyboard/notes affordances. We need a clearer mobile action, a touch-optimized immersive review experience, and stable visual coverage for the phone layout.
Implementation
OPEN_TOUCH_REVIEW_IMMERSIVE) so the header menu can request immersive review without coupling directly to sidebar internals.(max-width: 768px) and (pointer: coarse)) so narrow desktop windows keep keyboard-first behavior.RightSidebarto handle the touch immersive event by selecting/opening the review tab and enabling immersive review in touch mode.RightSidebar -> ReviewPanel -> ImmersiveReviewViewwith touch-indicative naming.ImmersiveReviewViewtouch mode:App/PhoneViewportsstoryIPhone17ProMaxTouchReviewImmersivethat:hasTouch: true,Validation
make typecheckmake lintmake static-checkmake storybook-buildmake test-storybookRisks
Low-to-moderate UI behavior risk, isolated to workspace-header action wiring and immersive review rendering/interaction paths. Desktop keyboard-first immersive flow remains the default path and was kept intact.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.12