fix(diff): accept/deny search all windows in current tab#211
Open
CoinCheung wants to merge 1 commit intocoder:mainfrom
Open
fix(diff): accept/deny search all windows in current tab#211CoinCheung wants to merge 1 commit intocoder:mainfrom
CoinCheung wants to merge 1 commit intocoder:mainfrom
Conversation
Previously, ClaudeCodeDiffAccept and ClaudeCodeDiffDeny required the cursor to be in the diff buffer itself. If the cursor was in another window within the same tab (e.g. the terminal split, or the original file side of the diff), the commands would fail with "No active diff found in current buffer". Add a local helper `find_diff_buf_in_current_tab()` that searches all windows in the current tabpage for a buffer with `claudecode_diff_tab_name` set. Both accept and deny now fall back to this search when the current buffer is not a diff buffer. Also add `nvim_tabpage_list_wins` to the vim mock and a new test spec covering the direct and fallback paths for both commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ClaudeCodeDiffAccept and ClaudeCodeDiffDeny required the cursor to be in the diff buffer itself. If the cursor was in another window within the same tab (e.g. the terminal split, or the original file side of the diff), the commands would fail with "No active diff found in current buffer".
Add a local helper
find_diff_buf_in_current_tab()that searches all windows in the current tabpage for a buffer withclaudecode_diff_tab_nameset. Both accept and deny now fall back to this search when the current buffer is not a diff buffer.Also add
nvim_tabpage_list_winsto the vim mock and a new test spec covering the direct and fallback paths for both commands.