feat: Ensure ClaudeCodeAdd correctly escapes file path argument#210
Open
HsiuCL wants to merge 1 commit intocoder:mainfrom
Open
feat: Ensure ClaudeCodeAdd correctly escapes file path argument#210HsiuCL wants to merge 1 commit intocoder:mainfrom
HsiuCL wants to merge 1 commit intocoder:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ClaudeCodeAddcommand to correctly handle file paths containing spaces by adding a backslash-escape-aware argument parser. Previously,vim.split(args, "%s+")would incorrectly split escaped paths likefile\ name.luainto separate tokens, breaking file resolution and potentially misinterpreting path fragments as line numbers.Changes
Escaped argument parser
parse_escaped_args()function that respects backslash-escaped spaces (\) and escaped backslashes (\\) when splitting command-line argumentsvim.split(opts.args, "%s+")withparse_escaped_args(opts.args)in theClaudeCodeAddcommand handler\is preserved as a literal space within a tokenTest coverage
file\ 1is treated as a path, not path + line number)Notable Details
\(escaped space) and\\(escaped backslash). Other escape sequences pass the backslash through unchanged, matching shell-like conventions.