Skip to content

fix(site): make YouTube demo thumbnail clickable - #267

Merged
codeforstartups merged 1 commit into
codeforstartups:developmentfrom
GITHUBTANMAY2003:fix/issue-260-youtube-demo
Sep 30, 2026
Merged

codeforstartups merged 1 commit into
codeforstartups:developmentfrom
GITHUBTANMAY2003:fix/issue-260-youtube-demo

Conversation

@GITHUBTANMAY2003

Copy link
Copy Markdown
Contributor

Description

Makes the YouTube demo thumbnail on the dynavec landing page open the correct video in a new tab.

The static facade is converted into a semantic link while preserving its existing appearance and improving keyboard accessibility.

Related issue

Fixes #260

Changes

  • Converted the YouTube facade from a static div and nested button into a semantic anchor.
  • Added the correct YouTube video URL with safe new-tab attributes.
  • Replaced the nested button with a decorative play-icon span.
  • Removed obsolete iframe-specific CSS.

Testing

  • Manually verified that clicking the thumbnail opens the correct video in a new tab.
  • Verified keyboard navigation and Enter-key activation.
  • Ruff checks pass.
  • Mypy passes.
  • Semantic Kernel tests pass separately (8 passed).
  • Remaining test suite passes with two optional tests skipped.
  • Documentation updated, if applicable (not required).

The combined local Pytest run encountered a pre-existing optional-dependency import-order conflict between DSPy and Semantic Kernel; both test groups pass when run separately.

Checklist

  • My changes are focused and relevant to this pull request.
  • I have added or updated tests where appropriate.
  • I have reviewed my changes for unrelated modifications.
  • I have updated documentation where necessary.

Coordination note

Raised at @tikhandesanket’s request because PR #265 also modifies the same landing-page section. This focused PR isolates the issue #260 implementation so the overlapping changes can be reviewed and reconciled.

@codeforstartups codeforstartups left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix — the YouTube facade was a dead <div role="button"> with no working click handler (its iframe-loading JS had been removed in an earlier landing edit), so the demo video wasn't actually clickable. This swaps it for a proper accessible <a href> that opens the video in a new tab (rel="noopener noreferrer", clear aria-label) and drops the now-dead iframe CSS. Small, correct, and more accessible than a div-button.\n\n(The earlier test (3.12) red was a transient PyPI network flake during install, unrelated to this landing-only change — I re-ran it and all 4 checks are green.) Merging — thanks @GITHUBTANMAY2003! 🙌

@codeforstartups
codeforstartups merged commit ea62fe7 into codeforstartups:development Sep 30, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: YouTube demo button does not open the video.

2 participants