Repository navigation
fix(site): make YouTube demo thumbnail clickable - #267
Merged
codeforstartups merged 1 commit intoSep 30, 2026
Merged
codeforstartups merged 1 commit into
codeforstartups merged 1 commit into
Conversation
codeforstartups
approved these changes
Sep 30, 2026
codeforstartups
left a comment
Owner
There was a problem hiding this comment.
Good fix — the YouTube facade was a dead <div role="button"> with no working click handler (its iframe-loading JS had been removed in an earlier landing edit), so the demo video wasn't actually clickable. This swaps it for a proper accessible <a href> that opens the video in a new tab (rel="noopener noreferrer", clear aria-label) and drops the now-dead iframe CSS. Small, correct, and more accessible than a div-button.\n\n(The earlier test (3.12) red was a transient PyPI network flake during install, unrelated to this landing-only change — I re-ran it and all 4 checks are green.) Merging — thanks @GITHUBTANMAY2003! 🙌
codeforstartups
merged commit Sep 30, 2026
ea62fe7
into
codeforstartups:development
7 of 8 checks passed
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the YouTube demo thumbnail on the dynavec landing page open the correct video in a new tab.
The static facade is converted into a semantic link while preserving its existing appearance and improving keyboard accessibility.
Related issue
Fixes #260
Changes
divand nested button into a semantic anchor.Testing
8 passed).The combined local Pytest run encountered a pre-existing optional-dependency import-order conflict between DSPy and Semantic Kernel; both test groups pass when run separately.
Checklist
Coordination note
Raised at @tikhandesanket’s request because PR #265 also modifies the same landing-page section. This focused PR isolates the issue #260 implementation so the overlapping changes can be reviewed and reconciled.