This repository was archived by the owner on Jan 28, 2023. It is now read-only.
Add slack notifications for Travis builds#122
Open
rhoegg wants to merge 4 commits into
Open
Conversation
smurphy8
suggested changes
Mar 2, 2017
smurphy8
left a comment
smurphy8
left a comment
There was a problem hiding this comment.
Is there some where this was tested or do we need to merge to test?
Author
|
Yes, sort of? :) Turns out the encrypted token is tied to the repository path, so I couldn't test the exact PR in my own repo. I tested with my own token on a separate branch "ryan-test-build" |
|
I think this is a cool idea, probably needs to be done at a hack night virtual or otherwise so that we can make sure it is all working. |
Author
|
I did it at the last one :) I think we just need to merge it.
…On Fri, Mar 17, 2017 at 4:31 PM, smurphy8 ***@***.***> wrote:
I think this is a cool idea, probably needs to be done at a hack night
virtual or otherwise so that we can make sure it is all working.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACuDw5yCyYpI_0a6AiqQangabPMHU10ks5rmvuxgaJpZM4MN4Ds>
.
|
|
Okay I will merge when I get in tonight.
On Mon, Mar 20, 2017 at 10:03 AM, Ryan Hoegg <notifications@github.com>
wrote:
… I did it at the last one :) I think we just need to merge it.
On Fri, Mar 17, 2017 at 4:31 PM, smurphy8 ***@***.***>
wrote:
> I think this is a cool idea, probably needs to be done at a hack night
> virtual or otherwise so that we can make sure it is all working.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/codeforokc/openbudgetokc/pull/
122#issuecomment-287476429>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AACuDw5yCyYpI_
0a6AiqQangabPMHU10ks5rmvuxgaJpZM4MN4Ds>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALJjGnqC93oUR2MnE1Dl2i0JxPEeo1hks5rnpVSgaJpZM4MN4Ds>
.
--
Scott Murphy
scottmurphy09@gmail.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.