Skip to content

fix(core): import works on a store with no embedding backend (#1166) - #1606

Merged
ajianaz merged 1 commit into
developfrom
fix/import-without-embedder
Oct 30, 2026
Merged

ajianaz merged 1 commit into
developfrom
fix/import-without-embedder

Conversation

@ajianaz

@ajianaz ajianaz commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

What

Uteke::import skips the embedder and the duplicate check when the store has no embedding backend (embedder_backend empty, #1166), so the rows are stored keyword-only like remember does there. With a backend the behaviour is unchanged. CHANGELOG Fixed entry under 0.22.0.

Why

Raised by the Cora review of the v0.22.0 release PR (#1603): the import asked the embedder for every row and failed on the first one on a store opened without a backend (open_with_backend(.., None)). This is old behaviour (v0.20.0 and v0.21.1 do the same), not a regression of the release, but it contradicts the keyword-only policy of remember and the release PR is blocked on it, so it is fixed rather than waved through.

Testing

  • cargo fmt, cargo clippy --workspace --all-targets --locked -- -D warnings, cargo test --workspace --locked.
  • New test a_store_without_an_embedder_imports_keyword_only: two rows import, are counted and found by keyword search; it fails without the change (checked by reverting it).
  • Touches the import path, so the benchmark guard applies: LongMemEval fast50 on Modal for this commit (result in a comment before the merge). The harness always has an embedder, so the changed branch is not taken there.

The import asked the embedder for every row and failed on the first one when no backend was configured. It now imports keyword-only like remember: no vector, no duplicate check.
@github-actions

Copy link
Copy Markdown

🔍 Cora AI Code Review

✅ No issues found. Code looks good!


Review powered by cora-code · BYOK · MIT

@ajianaz

ajianaz commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

Benchmark guard (import path touched): LongMemEval fast50 on Modal for 730f2f4: overall R@5 0.9800 vs 0.9800 baseline, 0 improved / 0 regressed (compare_fast50.py).

@ajianaz
ajianaz merged commit 1e2f3c6 into develop Oct 30, 2026
14 checks passed
@ajianaz
ajianaz deleted the fix/import-without-embedder branch October 30, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant