Repository navigation
fix(core): import works on a store with no embedding backend (#1166) - #1606
Merged
Merged
Conversation
The import asked the embedder for every row and failed on the first one when no backend was configured. It now imports keyword-only like remember: no vector, no duplicate check.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
Collaborator
Author
|
Benchmark guard (import path touched): LongMemEval fast50 on Modal for 730f2f4: overall R@5 0.9800 vs 0.9800 baseline, 0 improved / 0 regressed (compare_fast50.py). |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Uteke::importskips the embedder and the duplicate check when the store has no embedding backend (embedder_backendempty, #1166), so the rows are stored keyword-only likerememberdoes there. With a backend the behaviour is unchanged. CHANGELOG Fixed entry under 0.22.0.Why
Raised by the Cora review of the v0.22.0 release PR (#1603): the import asked the embedder for every row and failed on the first one on a store opened without a backend (
open_with_backend(.., None)). This is old behaviour (v0.20.0 and v0.21.1 do the same), not a regression of the release, but it contradicts the keyword-only policy ofrememberand the release PR is blocked on it, so it is fixed rather than waved through.Testing
cargo fmt,cargo clippy --workspace --all-targets --locked -- -D warnings,cargo test --workspace --locked.a_store_without_an_embedder_imports_keyword_only: two rows import, are counted and found by keyword search; it fails without the change (checked by reverting it).