Repository navigation
test(core): let tests supply an embedder through the public open path (#1542) - #1545
Merged
Merged
Conversation
…#1542) test_support gains open_with_embedder(_at) and RecordingEmbedder. The 33 core tests ignored because Uteke::open needs the ONNX runtime now run with the keyword embedder.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test_supportgainsopen_with_embedder/open_with_embedder_at(a store built with a caller-chosen embedder) andRecordingEmbedder(records every text, can fail its first N calls);open_keyword*delegate to them.write_path_testsdrops its private fake for the shared one.#[ignore]becauseUteke::openneeds the ONNX runtime now use the deterministic keyword embedder and run in CI (room, dedup, fusion, doc chunks, wikilink enrichment, verify/repair, explain). Three needed an explicit type (remember_typed) or a non-identical text because they relied on the real model's classifier or on bypassing dedup.Why
Part of #1543 (#1542). Those tests were never run in CI, so the code they cover had no regression check. Production code is unchanged.
Testing
cargo test --workspace: core lib 871 passed, 0 ignored; fmt, clippy-D warnings, docgen (no diff).