Skip to content

refactor: read [tier], [dream] and [lifecycle] into the core types (#1515, part 1) - #1528

Merged
ajianaz merged 1 commit into
developfrom
refactor/engine-settings-1
Oct 22, 2026
Merged

ajianaz merged 1 commit into
developfrom
refactor/engine-settings-1

Conversation

@ajianaz

@ajianaz ajianaz commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

What

First step of #1515 (option B, staged): the schema of three sections lives in one place. uteke_core::{TierConfig, DreamConfig, LifecycleConfig} implement serde::Deserialize (each key optional, the core default for the rest; negative tier days are still rejected). The CLI config uses them as its section types (type aliases, like ExtractionConfig), so its three mirror structs and to_core disappear; the server drops TierFileSection, DreamFileSection, LifecycleFileSection and the field-by-field unwrap_or chains, and the lifecycle background thread reads the same struct.

Why

The same keys and defaults were written three times (core, CLI, server) and had to be kept equal by hand. Next parts do [recall] and [embed_fallback], then one apply step for CLI, server and MCP (closes #1355). Refs #1515.

Testing

  • clippy -D warnings, fmt, cargo test --workspace pass; cargo run -p docgen changes nothing
  • 4 new core tests (documented defaults, partial sections, negative tier days rejected, wrong types are errors)
  • side by side: the CLI built from develop and from this branch, run with the same uteke.toml (partial, full and invalid sections), print identical uteke lifecycle status --json output and the same invalid-config warning
  • reviewed locally with the Cora MCP agent reviewer before pushing: no blocking finding, no deterministic finding

@github-actions

Copy link
Copy Markdown

🔍 Cora AI Code Review

✅ No issues found. Code looks good!


Review powered by cora-code · BYOK · MIT

@ajianaz
ajianaz merged commit d546000 into develop Oct 22, 2026
15 checks passed
@ajianaz
ajianaz deleted the refactor/engine-settings-1 branch October 22, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: unify the mirrored config schema structs (CLI Config vs server ServerFileConfig)

1 participant