Repository navigation
refactor: read [tier], [dream] and [lifecycle] into the core types (#1515, part 1) - #1528
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First step of #1515 (option B, staged): the schema of three sections lives in one place.
uteke_core::{TierConfig, DreamConfig, LifecycleConfig}implementserde::Deserialize(each key optional, the core default for the rest; negative tier days are still rejected). The CLI config uses them as its section types (type aliases, likeExtractionConfig), so its three mirror structs andto_coredisappear; the server dropsTierFileSection,DreamFileSection,LifecycleFileSectionand the field-by-fieldunwrap_orchains, and the lifecycle background thread reads the same struct.Why
The same keys and defaults were written three times (core, CLI, server) and had to be kept equal by hand. Next parts do
[recall]and[embed_fallback], then one apply step for CLI, server and MCP (closes #1355). Refs #1515.Testing
-D warnings, fmt,cargo test --workspacepass;cargo run -p docgenchanges nothingdevelopand from this branch, run with the sameuteke.toml(partial, full and invalid sections), print identicaluteke lifecycle status --jsonoutput and the same invalid-config warning