Repository navigation
refactor(core): transports use Uteke accessors, not the store (#1521) - #1527
Merged
Merged
Conversation
… the private rooms module (#1521)
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Item 8 of the round-2 deepening epic (#1523). The server, the CLI and MCP no longer reach past
Uteke:Uteke::store()andUteke::graph_store()arepub(crate); transports usecount_active,list_deprecated(new, next to the existingcount_deprecated) andgraph()(the knowledge graph without the raw SQLite connection). The transport test suites seed rows throughstore_for_tests(), which exists only behind thetest-supportfeature. The private module holding theUtekeroom operations is renamedroom_opsso it stops sharing a name withmemory::rooms. The one-line room forwarders stay: they are the facade that keepsStoreprivate (the issue text was corrected on this).Why
Handlers that call
uteke.store().count_activeor build aGraphStorefrom the raw connection depend on the storage layer, so the seam leaks. The compiler now enforces it. Breaking for crates that depend onuteke-coreand called the two accessors (noted in the CHANGELOG; 0.x minor). No wire or CLI behaviour change. Refs #1521.Testing
-D warnings, fmt,cargo test --workspacepass;cargo run -p docgenchanges nothingUteke; the graph reachable throughgraph());grepshows nostore()/graph_store()call left in the server, CLI or MCP, and the compiler would reject oneunwraphints in test fixtures)