Repository navigation
chore(deps): ort 2.0.0-rc.14 with an explicit Environment - #1513
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
ortto 2.0.0-rc.14 (the dependabot PR #1495 cannot build). rc.14 builds a session from an explicitEnvironmentand removedEnvironmentBuilder::commit:embed::ort_initnow builds the one process-wide environment (init_from(...).build(), kept in a static, exposed asenvironment()) andOnnxEmbedderpasses it toSession::builder. The version requirement inuteke-core/Cargo.toml, an error message anddocs/install.mdsay rc.14. The bundled ONNX Runtime stays at 1.24.4; theapi-18feature is unchanged.Why
Keeps the ONNX stack current and unblocks the dependabot bump. Small blast radius: two call sites.
Testing
-D warnings, fmt andcargo test --workspacepass (CI has no ONNX Runtime library, so the embedder tests do not run there)ORT_LIB_PATH) and the EmbeddingGemma model in a throwawayUTEKE_HOME:uteke rememberreturnedembedding_written: trueanduteke recallwith a paraphrased query found the memory.