Repository navigation
docs: Test is a required check of the develop and main rulesets (#1467) - #1512
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/isolation-suite.mdsaidTesthad to be made a required check. It already is: both thedevelop-protectedandmain-protectedrulesets listTestin their required status checks, and the job runscargo test --workspace, which includes the isolation suites. The document now says so, with the date it was checked.Why
The last open acceptance criterion of #1467 ("marked required in branch protection") is met; the doc should not tell readers to do it. Refs #1467.
Testing
gh api repos/codecoradev/uteke/rulesets:Testis in the required checks of both rulesets.