Repository navigation
feat(core): read [privacy] from uteke.toml in the CLI, server and MCP (#1464, part 2b-2a) - #1508
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
[privacy]inuteke.toml(mode=redact|strict|off,allowlistregexes) andUTEKE_PRIVACY_MODEnow configure the secret filter. One loader,privacy::load_config(), is used by the CLI,uteke-serveanduteke-mcp. The section is in the untrusted project keys: only the global file is read for it, so a cloned repository cannot switch the filter off or allowlist everything. An unknown mode or an invalid regex falls back to the default for that setting (a bad regex keepsstrict, a bad mode keeps the allowlist); the filter never turns itself off because of a typo. Documented indocs/configuration.md.Why
Part of #1464. Until now the write path used the built-in default (
redact) with no way to change it. Response fields and the strict 400 body follow in 2b-2b. Refs #1464.Testing
-D warnings, fmt andcargo test --workspacepass;cargo run -p docgenchanges nothing[privacy](reported inignored_untrusted)