Repository navigation
feat(core): apply the privacy filter on remember, update and import (#1464, part 2b-1b) - #1507
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wires the detector into the core write paths:
remember,remember_with_contradiction, room remember,update_memoryandimportmask secrets in the content before it is embedded or stored.metadata.redacted/redactionscarry kinds and counts (never values), aredactedtimeline event is recorded, strict mode returnsError::SecretDetected(import skips the row), andupdate_memorykeeps the flags consistent with the content for content-only, metadata-only and content+metadata edits. The CLI debug log prints only a byte length.Why
Part of #1464: secrets are stripped before persisting. Known limits (metadata, tags,
source, structural import, consolidation, LLM extraction) are listed in the CHANGELOG and follow in a separate PR; the[privacy]config section and response fields are 2b-2. Refs #1464.Testing
-D warnings, fmt andcargo test --workspacepassprivacy_write_tests.rs, including a scan of the SQLite and index file bytes for the secret and the content+metadata update cases