Repository navigation
feat(core): privacy filter assignment scanner with name segmentation and benign values (#1464, part 2b-1a) - #1506
Merged
Conversation
…and benign values (#1464, part 2b-1a)
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the single-regex assignment rule with a scanner: a secret-like name must end in a whole secret word (
API_KEY,DB_PASS,apiKey; qualifiers like_PRODignored), the value is read whole (quotes, escaped JSON,:=,=>, table cells,&/;boundaries, passwords with,or\), and benign values (paths, ARNs, digests, versions, ULIDs, dates, emails, shell references, identifiers, placeholders) are left alone. The shared vectors are complete at version 3 (192 cases). A block of key lines is followed to its end, up to 1 MiB.Why
Part of #1464. The first detector was unsafe by default (139 of 330 benign cases flagged, 62 of 147 secrets missed on the review corpus); this one measures 3 and 16. Still not wired to a write path; that is the next PR. Refs #1464.
Testing
-D warningsand fmt clean on the workspacecargo test -p uteke-core --lib privacypasses (19 tests, including all 192 shared vectors, name segmentation and a hostile-input timing test)