Repository navigation
build: enforce the unsafe_code lint in every crate (#1456) - #1483
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
ajianaz
force-pushed
the
fix/enforce-unsafe-code-lint
branch
from
October 16, 2026 00:50
eeff255 to
189bd22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cargo.toml:unsafe_code = "forbid"becomes"deny".uteke-core,uteke-cli,uteke-mcp,uteke-server,docgen) gets[lints] workspace = true, so the level is applied for real.std::env::set_var/remove_var(unsafein edition 2024) get#[allow(unsafe_code)]:config.rstests,main.rsresolve_store_tests,uteke-corelib.rs(two modules) andembed/ort_init.rstests.Why
The workspace declared
forbidbut no crate inherited it, so nothing was enforced and the skill's "unsafe_code = "forbid"workspace-wide" claim was untrue.forbidcannot be relaxed per module, so the tests that mutate the environment would not compile;denyplus a scoped allow keeps production code strictlyunsafe-free. All 95 existingunsafeblocks are in test modules. Closes #1456.Testing
cargo clippy --workspace --all-targets -- -D warningsis clean with the lints inherited.unsafeblock added to non-test code inuteke-mcpfails the build ("usage of anunsafeblock"); it was removed afterwards.cargo test --workspace: 1086 passed, 0 failed.