Repository navigation
fix(mcp): tools/list shows a read-only caller only the read tools (#1446) - #1482
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tools/listonPOST /mcpreturns only the names inREAD_ONLY_TOOLSto a read-only caller (the dispatch aliasuteke_room_documentis never advertised). Full-access callers, the stdio transport andtools/call(with its own gate) are unchanged. No tool is added, renamed or removed and no schema changes. CHANGELOG entry added.Why
Since #1441 a read-only token can call the read tools and gets a tool error from the write tools, but
tools/liststill advertised everything, so an agent planned around tools it could not use. MCP is CORE: the contract question is uteke-cloud#203, and the owner approved the change there. Closes #1446.Testing
read_only_tools_list_is_exactly_the_read_tools: the read-only list equalsREAD_ONLY_TOOLSminus the alias, is a subset of the full list, the full catalog stays at 49 tools, anduteke_remember,uteke_forgetanduteke_doc_createare hidden from read-only.cargo test -p uteke-mcp -p uteke-serverpasses;cargo clippy --all-targets -D warningsandcargo fmtare clean.