Repository navigation
fix(cli): upgrade error hints no longer recommend the verification bypass (#1475) - #1481
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The three
uteke upgradeerrors for a missing or failed checksums download (HTTP error, network error, archive not listed) no longer say "Set UTEKE_UPGRADE_SKIP_CHECKSUM=1". They say the install is refused, to retry later, and point at the manual verification section of SECURITY.md (SIGNATURE_HELP). The two download errors share one helper,checksums_unavailable. The bypass itself and its warning block are unchanged and stay documented in SECURITY.md.Why
Since #1462 that variable also disables the minisign signature check, so a transient 5xx or rate limit used to suggest dropping the whole verification chain, and a copy-pasted hint ran an unverified binary. Closes #1475.
Testing
error_hints_never_recommend_the_bypasspins the wording of all three messages (noUTEKE_UPGRADE_SKIP_CHECKSUM, mentions SECURITY.md, keeps the HTTP detail and "retry later").cargo test -p uteke-cli upgrade: 29 pass.cargo clippy --all-targets -D warningsandcargo fmtare clean.