Repository navigation
ci: pass the PR base branch to the Cora review action - #1386
Merged
Merged
Conversation
The action defaults base-branch to origin/develop. For PRs into main (release PRs, whose head carries develop's tree) git diff origin/develop...HEAD is empty, so Cora reported 'empty result' and never reviewed the release diff (#1380: 0 files vs 58 against main). Same root cause as homebrew-tap#5/#6. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
Collaborator
Author
|
Probe result (throwaway draft PR #1387 into |
ajianaz
added a commit
that referenced
this pull request
Oct 8, 2026
… tracker is (#1388) - the mandatory main->develop sync PR cannot be merged (merge commits are rejected, squash/rebase drop the -s ours merge, #1381): replace the rule with the per-release 'merge main with the develop side' branch actually used for v0.20.0 - write the release procedure end to end (pre-flight, prep PR, release branch, squash to main, tag after merge, Homebrew tap, production verify) - Cora: a real verdict is required; the job now diffs against the PR base (#1386) - uteke-cloud's tracker is Gitea, the GitHub repo is a stale mirror Co-authored-by: ajianaz <ajianaz@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pass
base-branch: origin/${{ github.base_ref }}tocodecoradev/cora-review-action@v1in.github/workflows/cora-review.yml.Why
The action's
base-branchdefaults toorigin/develop. PRs intodevelopwere fine, but for PRs intomainthe review diffed againstdevelop: on the v0.20.0 release PR (#1380)git diff origin/develop...<head>had 0 files (head = develop's tree + a-s oursmerge of main) while the real diff againstmainhad 58, so Cora returned "empty result" and never reviewed it. The same root cause made the formula PRs inhomebrew-tapfail (fixed there in codecoradev/homebrew-tap#6, reproduced with the Cora CLI:--base origin/developaborts with an unknown-revision error / empty diff,--base origin/mainproduces a SARIF). I had first attributed the #1380 result to diff size; that was wrong (corrected on #1380).Testing
develop, where the new value equals the old default, so it must behave exactly as before: the Cora verdict below should be a real one.main) is exercised with a throwaway draft PR from achore/release-*branch tomain, closed unmerged; its result is posted as a comment here.🤖 Generated with Claude Code