You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(core): lift the redaction flag policy out of update_memory_detailed #1520
update_memory_detailed (~200 lines) mixes validation, masking of three inputs, merging redaction counts, a five-arm match that decides which redacted / redactions flags survive each kind of edit, and the re-embed and write. The match is correct (it is covered by tests) but it is a policy table written inline, and it leans on the magic string [REDACTED:.
Direction
Give the flag policy its own module that can be tested without a store, and let update shrink to validate, mask, write.
Behaviour impact
None. The policy table must be preserved exactly (existing tests in privacy_write_tests.rs are the guard).
Acceptance
The policy is a pure function with its own tests (no SQLite).
Done in #1525: the policy is redaction_flags::resolve, a pure function with one test per rule; update_memory_detailed lost its inline match. No behaviour change.
Activity
refactor(core): redaction flag policy as its own module (#1520) (#1525)
ajianaz commentedon Oct 22, 2026
Done in #1525: the policy is
redaction_flags::resolve, a pure function with one test per rule;update_memory_detailedlost its inline match. No behaviour change.