Repository navigation
fix(spa): 404 for missing assets; persist selected project - #354
Merged
Merged
Conversation
- spa: asset-like paths (file extension or /_app/) that are not embedded return 404 instead of index.html (#310) - web: remember selected project in localStorage across issues/transactions/release-health/rules (#311) - trapfalld: build.rs warns when web/build/_app is missing (#307) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
spa.rs: asset-like paths (final segment has an extension, or under_app/) that are not embedded now return 404. Extension-less client routes still fall back toindex.html.lib/project-selection.ts). Resolution order: valid?project=, stored value, first project.trapfalld/build.rs: emits a cargo warning whenweb/build/_appis missing (a fresh clone only tracks a placeholderindex.html, so the dashboard is blank withoutnpm run build). Relates to bug(ui): dashboard renders blank on fresh clone — web/build assets not in git but embedded at compile time #307 (not closed here).Why
Missing JS/CSS returned
index.htmlwith 200, hiding build problems and confusing browsers. Project choice was lost when navigating between pages.Testing
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspaceall pass.npm ci,npm run check(0 errors),npm test(newproject-selection.test.ts),npm run buildall pass.Closes #310
Closes #311
🤖 Generated with Claude Code